Descent (Fiery Star Press, Edinburgh, 1968) - available from Zoilus Press
A Truth Lover (Akros Publications, Preston, 1973)
Memoirs of my Aunt Minnie/Clapperton (Rainbow Books, Aberdeen, 1974)
Pagan's Pilgrimage (Akros Publications, Preston, 1978)
Stories Short & Tall (Caithness Books, Thurso, 1979) - available direct from John Herdman
Voice Without Restraint: Bob Dylan's Lyrics & their Background (Paul Harris Publishing, Edinburgh, 1982; Delilah Books, New York, 1982; (Japanese translation) CBS/Sony Publishing, Tokyo, 1983) - available on CD from Zoilus Press
Three Novellas (Polygon Books, Edinburgh, 1987) - OOP
The Double in Nineteenth Century Fiction (The Macmillan Press, London, 1990; St Martin's Press, New York, 1991) - available from James Thin and from Macmillan Press on order.
Imelda & Other Stories (Polygon, Edinburgh, 1993)
Ghostwriting (Polygon, Edinburgh, 1996)
Cruising: A Play in Two Acts (diehard publishers, Edinburgh, 1997)
Poets, Pubs, Polls & Pillar Boxes (Akros Publications, Kirkcaldy, 1999) - OOP
Four Tales, with an introduction by MacDonald Daly (Zoilus Press, London, 2000)
The Sinister Cabaret (Black Ace Books, Forfar, 2001)
Triptych: Three Tales (fras Publications< Blair Atholl, 2004)
Imelda, trans. with a post-face by Maïca Sanconie (Quidam Editeur, Paris, 2006)
My Wife's Lovers: Ten Tales (Black Ace Books, Perth, 2007)

Edited:

Third Statistical Account of Scotland:

* Vol. XXIII, The County of Berwick (Scottish Academic Press, Edinburgh, 1992)
* Vol. XXVIII, The County of Roxburgh (Scottish Academic Press, Edinburgh, 1992)

Move Up, John, by Fionn MacColla (Canongate, Edinburgh, 1994)

Contributor to:

Whither Scotland?, ed. Duncan Glen (Victor Gollancz, London, 1971)
Essays on Fionn MacColla, ed. David Morrison (Caithness Books, Thurso, 1973) - available from James Thin
Jock Tamson's Bairns, ed. Trevor Royle (Hamish Hamilton, London, 1977)
Twentieth Century Literature of Criticism, Vol. 15 (Gale Research Co., Detroit, 1985)
Essays on Sorley MacLean, ed. Joy Hendry & Raymond J. Ross (Scottish Academic Press, Edinburgh, 1986)
The Devil & the Giro: Two Twentieth Centuries of Scottish Stories, ed. Carl MacDougall (Canongate, Edinburgh, 1989)
The Day I Met the Queen Mother (New Writing Scotland 8) (ASLS, Aberdeen, 1990)
The Devil & Dr Tuberose (Scottish Short Stories 1991) (Harper Collins, London, 1991)
Nineteenth Century Literature Criticism, Vol. 40 (Gale Research Co., Detroit, 1993)
The Picador Book of Contemporary Scottish Fiction, ed. Peter Kravitz (Picador, London, 1997)
Marilynre várva: Mai skót novellák (Pannónia Könyvek, Hungary, 1998)
The Keekin-Gless: An Anthology from Perth & Kinross, ed. R.A. Jamieson & Carl MacDougall (Perth & Kinross Libraries, Perth, 1999)
Figures of Speech: An Anthology of Magdalene Writers, ed. M.E.J. Hughes, John Mole, Nick Seddon (Magdalene College, Cambridge, 2000)
The Lie of the Land: Poems and Stories from Perth & Kinross, ed. Brian McCabe et al. (Perth and Kinross Libraries, Perth, 2004)
The Oxford Dictionary of National Biography, ed. Colin Matthew and Brian Harrison (Oxford University Press, Oxford, 2004)
Bringing Back Some Brightness: 20 Years of New Writing Scotland (NWS 22), ed. Valerie Thornton and Hamish Whyte (ASLS, Glasgow, 2004)